Multi-platform & multi-version CI #176
Conversation
vaind
commented
Jan 25, 2021
•
vaind
commented
- closes CI on macOS and Windows #80
- closes CI - test all supported dart/flutter versions #82
vaind
force-pushed
the
multiplatform-ci
branch
19 times, most recently
from
e9305c3 to
16e5905
Compare
include relative and absolute paths where install.sh puts the lib
vaind
force-pushed
the
multiplatform-ci
branch
from
16e5905 to
fb6fb10
Compare
lib/src/bindings/flatbuffers.dart
Outdated
| DynamicLibrary lib; | ||
| if (Platform.isWindows) { | ||
| // DynamicLibrary.process() is not available on Windows | ||
| lib = DynamicLibrary.open('msvcr100.dll'); |
There was a problem hiding this comment.
Where is this workaround coming from? Appears to be a C library. Does this require installation of Microsoft Visual C++ 2015 Redistributable (x64) like mentioned at https://docs.objectbox.io/java-desktop-apps#native-libraries? Should this be noted in a README?
The GitHub Windows instance has a bunch of versions installed, so I guess most are fine. https://github.com/actions/virtual-environments/blob/win19/20201210.0/images/win/Windows2019-Readme.md#microsoft-visual-c
There was a problem hiding this comment.
Where is this workaround coming from?
Nowhere in particular, I've just searched what libary defines memset on windows. Turns out it's mscvrt.dll or mscvr100.dll. Yes it may be fragile even though the library is pretty common, some users might not have it... I'll add another fallback layer
There was a problem hiding this comment.
Maybe add this in a comment then?
There was a problem hiding this comment.
OK, also added a comment
