Skip to content

added LaTex template for .tex files in LatexMojo#2082

Merged
rultor merged 8 commits into
objectionary:masterfrom
Graur:2067
May 25, 2023
Merged

added LaTex template for .tex files in LatexMojo#2082
rultor merged 8 commits into
objectionary:masterfrom
Graur:2067

Conversation

@Graur

@Graur Graur commented May 23, 2023 •
edited by pr-codex Bot
Loading

Copy link
Copy Markdown
Contributor

Closes: #2067

PR-Codex overview

This PR adds a LatexTemplate class that generates a standalone compilable LaTex document from the code in LaTex notation. It also refactors some parts of the code and adds license headers.

Detailed summary

  • Adds LatexTemplate class to generate standalone compilable LaTex documents
  • Refactors some parts of the code
  • Adds license headers

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@Graur Graur marked this pull request as ready for review May 23, 2023 14:46
@Graur

Graur commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

@volodya-lombrozo Please, have a look

@Graur Graur requested a review from volodya-lombrozo May 23, 2023 15:37
volodya-lombrozo
volodya-lombrozo suggested changes May 24, 2023
View reviewed changes
Comment thread eo-maven-plugin/src/test/java/org/eolang/maven/latex/TemplateGeneratorTest.java Outdated
Comment thread eo-maven-plugin/src/test/java/org/eolang/maven/latex/TemplateGeneratorTest.java Outdated
Comment thread eo-maven-plugin/src/test/java/org/eolang/maven/latex/TemplateGeneratorTest.java Outdated
Comment thread eo-maven-plugin/src/test/java/org/eolang/maven/latex/TemplateGeneratorTest.java Outdated
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/latex/TemplateGenerator.java Outdated
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/LatexMojo.java Outdated
@Graur

Graur commented May 24, 2023

Copy link
Copy Markdown
Contributor Author

@volodya-lombrozo Can you take a look again, please ?

volodya-lombrozo
volodya-lombrozo suggested changes May 24, 2023
View reviewed changes
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/latex/LatexTemplate.java Outdated
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/latex/LatexTemplate.java Outdated
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/latex/LatexTemplate.java Outdated
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/latex/package-info.java Outdated
Comment thread eo-maven-plugin/src/test/java/org/eolang/maven/latex/LatexTemplateTest.java Outdated
@Graur

Graur commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

@volodya-lombrozo I believe I fixed all of the suggestions, can you please take a look again?

@volodya-lombrozo

volodya-lombrozo commented May 25, 2023

Copy link
Copy Markdown
Member

@Graur Look good to me. Thank you!
@yegor256 Could you merge that changes, please?

@yegor256

yegor256 commented May 25, 2023

Copy link
Copy Markdown
Member

@rultor merge

@rultor

rultor commented May 25, 2023

Copy link
Copy Markdown
Contributor

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 34f9a76 into objectionary:master May 25, 2023
@rultor

rultor commented May 25, 2023

Copy link
Copy Markdown
Contributor

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@Graur Graur deleted the 2067 branch May 25, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@volodya-lombrozo volodya-lombrozo volodya-lombrozo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LatexMojo.java:45-48: Generate a standalone compilable...

4 participants

@Graur @volodya-lombrozo @yegor256 @rultor