Skip to content

feat(#3934): spdx meta instead of <license/> node#3959

Merged
maxonfjvipon merged 17 commits into
objectionary:masterfrom
h1alexbel:3934
Feb 27, 2025
Merged

feat(#3934): spdx meta instead of <license/> node#3959
maxonfjvipon merged 17 commits into
objectionary:masterfrom
h1alexbel:3934

Conversation

@h1alexbel

Copy link
Copy Markdown
Member

In this PR I've removed license as a commentary text from .eo program source, and as the result <license/> node from XMIR. License was replaced with +spdx meta.

closes #3934
History:

@h1alexbel h1alexbel changed the title feat(#3934): spdx meta instead of <license/> node feat(#3934): spdx meta instead of <license/> node Feb 26, 2025
@github-actions github-actions Bot added the core label Feb 26, 2025
@github-actions

github-actions Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 170.697 172.842 2.146 1.26% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 167.488 186.645 19.157 11.44% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 163.323 164.969 1.646 1.01% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 2.146 ms/op (1.26%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 19.157 ms/op (11.44%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 1.646 ms/op (1.01%)

@h1alexbel

Copy link
Copy Markdown
Member Author

@maxonfjvipon take a look, please

Comment thread REUSE.toml Outdated
Comment thread .github/workflows/copyrights.yml Outdated
@maxonfjvipon

Copy link
Copy Markdown
Member

@h1alexbel also you forgot to remove license from XMIR.xsd

@h1alexbel

h1alexbel commented Feb 26, 2025

Copy link
Copy Markdown
Member Author

@maxonfjvipon updated. Take a look, please (REUSE still expects license to be placed in comments)

@maxonfjvipon

Copy link
Copy Markdown
Member

@h1alexbel any plan how we can fix it?

@h1alexbel

Copy link
Copy Markdown
Member Author

@maxonfjvipon looks like we should add colon : between License-Identifier meta and identifier itself:

+spdx SPDX-License-Identifier: MIT

@h1alexbel

Copy link
Copy Markdown
Member Author

@maxonfjvipon updated. Take a look, please

@maxonfjvipon maxonfjvipon added this pull request to the merge queue Feb 27, 2025
Merged via the queue into objectionary:master with commit 8c2d901 Feb 27, 2025
@h1alexbel h1alexbel deleted the 3934 branch February 27, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<license/> in XMIR should have SPDX format, instead of raw text

3 participants