Skip to content

bug(#3986): fixed logging in ResolveMojo + renamed parameter#4005

Merged
yegor256 merged 2 commits into
objectionary:masterfrom
maxonfjvipon:bug/#3986/ignore-runtime
Mar 14, 2025
Merged

bug(#3986): fixed logging in ResolveMojo + renamed parameter#4005
yegor256 merged 2 commits into
objectionary:masterfrom
maxonfjvipon:bug/#3986/ignore-runtime

Conversation

@maxonfjvipon

@maxonfjvipon maxonfjvipon commented Mar 14, 2025

Copy link
Copy Markdown
Member

Ref: #3986

@github-actions github-actions Bot added the core label Mar 14, 2025
@maxonfjvipon maxonfjvipon changed the title bug(#3986): fixed logging in `` bug(#3986): fixed logging in ResolveMojo + renamed parameter Mar 14, 2025
@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 149.763 162.539 12.776 8.53% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 161.451 160.356 -1.095 -0.68% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 162.986 145.082 -17.904 -10.99% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 12.776 ms/op (8.53%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 1.095 ms/op (0.68%)
✅ Performance gain: benchmarks.XmirBench.xmirToSaltyPhi is faster by 17.904 ms/op (10.99%)

@yegor256 yegor256 added this pull request to the merge queue Mar 14, 2025
Merged via the queue into objectionary:master with commit e3fcecb Mar 14, 2025
@0crat

0crat commented Mar 20, 2025

Copy link
Copy Markdown

@maxonfjvipon Great work on your contribution! 🌟 You've earned +4 points: +4 base, -4 for minimal comments, but +4 to recognize your effort. We value your input and encourage you to keep the momentum going. Looking forward to more of your valuable contributions!

@0crat

0crat commented Mar 20, 2025

Copy link
Copy Markdown

@yegor256 Thanks for the review! You've earned +4 points: +4 as a basis, -24 for self-review, +0.01 per hit-of-code (capped at 16), -16 for no comments, and +24 to meet the minimum reward. Keep in mind that more comments and reviewing others' code can boost your points next time! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants