Skip to content

bug(#3986): added integration test for running program from jar#4012

Merged
yegor256 merged 5 commits into
objectionary:masterfrom
maxonfjvipon:bug/#3986/run-from-jar
Mar 17, 2025
Merged

bug(#3986): added integration test for running program from jar#4012
yegor256 merged 5 commits into
objectionary:masterfrom
maxonfjvipon:bug/#3986/run-from-jar

Conversation

@maxonfjvipon

@maxonfjvipon maxonfjvipon commented Mar 16, 2025

Copy link
Copy Markdown
Member

Ref: #3986

In this PR I've added an integration test that runs simple EO program from JAR in the same way we do it in eoc.
Also I've changed an implementation of package objects. Now they may have \rho attribute

@github-actions

github-actions Bot commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 158.597 173.512 14.916 9.40% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 179.423 195.247 15.825 8.82% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 136.726 151.787 15.061 11.02% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 14.916 ms/op (9.40%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 15.825 ms/op (8.82%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 15.061 ms/op (11.02%)

@github-actions github-actions Bot added the core label Mar 16, 2025
@github-actions github-actions Bot removed the core label Mar 16, 2025
@maxonfjvipon

Copy link
Copy Markdown
Member Author

@yegor256 please check

@yegor256 yegor256 added this pull request to the merge queue Mar 17, 2025
Merged via the queue into objectionary:master with commit c756840 Mar 17, 2025
@0crat

0crat commented Mar 20, 2025

Copy link
Copy Markdown

@maxonfjvipon Thank you for your contribution! Your effort is appreciated, but there are some areas for improvement. Based on our policy, you've earned 4 points: +4 as a base, -8 for exceeding 200 hits-of-code (327), and -4 for having only 2 comments. However, we've adjusted it to ensure you receive at least 4 points. For future contributions, please aim for more concise code and encourage more detailed reviews. Remember, quality over quantity is key. Looking forward to your next submission!

@0crat

0crat commented Mar 20, 2025

Copy link
Copy Markdown

@yegor256 Thanks for the review! You've earned +4 points for this contribution: +4 as a basis; -24 for self-review; +0.02 for 2 hits-of-code; -16 for no comments; -8 for less than 16 hits-of-code; +24 to meet the minimum reward. Keep up the good work and aim for more comments and code in future reviews! 💻👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants