Skip to content

bug(#4016): ensure package-info files are in jar#4033

Merged
yegor256 merged 14 commits into
objectionary:masterfrom
maxonfjvipon:bug/#4016/transpile-with-package-info
Mar 24, 2025
Merged

bug(#4016): ensure package-info files are in jar#4033
yegor256 merged 14 commits into
objectionary:masterfrom
maxonfjvipon:bug/#4016/transpile-with-package-info

Conversation

@maxonfjvipon

@maxonfjvipon maxonfjvipon commented Mar 22, 2025

Copy link
Copy Markdown
Member

Closes: #4016

In this PR I:

  1. removed CopyMojo because we don't need it anymore since MarkMojo is gone
  2. fixed PlaceMojo so it does not place jars anymore
  3. fixed TranspileMojo so it appends package-info.java files for all the directories in generated sources
  4. fixed UnspileMojo so it clears all the classes, including inner ones, compiled from generated sources
  5. fixed UnplaceMojo so it properly unplaces all the classes copies from 6-resolve directory
  6. fixed all the corresponding tests
  7. fixed eo-runtime configuration in pom.xml so package-info.class files are not touched while unspiling and unplacing

As the result - now we have eo-runtime.jar without unnecessary classes and with package-info.class files for every package, so it should help with #3986

@github-actions github-actions Bot added the core label Mar 22, 2025
@github-actions

github-actions Bot commented Mar 22, 2025

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 154.552 155.242 0.690 0.45% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 154.608 180.254 25.646 16.59% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 153.183 142.793 -10.390 -6.78% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 0.690 ms/op (0.45%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 25.646 ms/op (16.59%)
✅ Performance gain: benchmarks.XmirBench.xmirToSaltyPhi is faster by 10.390 ms/op (6.78%)

@maxonfjvipon

Copy link
Copy Markdown
Member Author

@yegor256 please check

Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/EmptyDirectoriesIn.java Outdated
Comment thread eo-maven-plugin/src/main/java/org/eolang/maven/EmptyDirectoriesIn.java Outdated

@yegor256 yegor256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments above

@maxonfjvipon

Copy link
Copy Markdown
Member Author

@yegor256 fixed, please check one more time

@yegor256 yegor256 enabled auto-merge March 24, 2025 07:09
@yegor256 yegor256 added this pull request to the merge queue Mar 24, 2025
Merged via the queue into objectionary:master with commit 6c539ef Mar 24, 2025
@0crat

0crat commented Mar 24, 2025

Copy link
Copy Markdown

@yegor256 Hello! Thank you for your code review. Based on our team policy, you've earned +16 points for this review: +4 as a base, +16 (max) for the 1573 hits-of-code you reviewed, and -4 for the limited number of comments (5). We encourage more detailed feedback in future reviews. Your updated balance is now -512. Keep up the good work and remember that thorough reviews benefit the entire team! 👍

@0crat

0crat commented Mar 24, 2025

Copy link
Copy Markdown

@maxonfjvipon Hey there! 👋 Great work on your contribution! You've earned +4 points, which is our base reward. We had to make some adjustments though: -8 for exceeding 200 hits-of-code (you hit 1573!), -16 for going over 800, and -4 because we only got 5 comments (we aim for at least 6). To keep you motivated, we added 28 points, bringing your total to +4. Remember, quality over quantity is key! Keep the contributions coming, but try to keep them more focused next time. Your current balance stands at +38. Looking forward to your next submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TranspileMojo does not generate package-info.java for packages without .eo files

3 participants