bug(#4016): ensure package-info files are in jar#4033
Conversation
🚀 Performance Analysis
|
|
@yegor256 please check |
|
@yegor256 fixed, please check one more time |
|
@yegor256 Hello! Thank you for your code review. Based on our team policy, you've earned +16 points for this review: +4 as a base, +16 (max) for the 1573 hits-of-code you reviewed, and -4 for the limited number of comments (5). We encourage more detailed feedback in future reviews. Your updated balance is now -512. Keep up the good work and remember that thorough reviews benefit the entire team! 👍 |
|
@maxonfjvipon Hey there! 👋 Great work on your contribution! You've earned +4 points, which is our base reward. We had to make some adjustments though: -8 for exceeding 200 hits-of-code (you hit 1573!), -16 for going over 800, and -4 because we only got 5 comments (we aim for at least 6). To keep you motivated, we added 28 points, bringing your total to +4. Remember, quality over quantity is key! Keep the contributions coming, but try to keep them more focused next time. Your current balance stands at +38. Looking forward to your next submission! |
Closes: #4016
In this PR I:
CopyMojobecause we don't need it anymore sinceMarkMojois gonePlaceMojoso it does not place jars anymoreTranspileMojoso it appendspackage-info.javafiles for all the directories in generated sourcesUnspileMojoso it clears all the classes, including inner ones, compiled from generated sourcesUnplaceMojoso it properly unplaces all the classes copies from6-resolvedirectoryeo-runtimeconfiguration inpom.xmlsopackage-info.classfiles are not touched while unspiling and unplacingAs the result - now we have
eo-runtime.jarwithout unnecessary classes and withpackage-info.classfiles for every package, so it should help with #3986