Skip to content

fix(#4032): Update XMIR format for bytes representation#4035

Merged
yegor256 merged 1 commit into
objectionary:masterfrom
volodya-lombrozo:4032_xmir_bytes_ready
Mar 24, 2025
Merged

fix(#4032): Update XMIR format for bytes representation#4035
yegor256 merged 1 commit into
objectionary:masterfrom
volodya-lombrozo:4032_xmir_bytes_ready

Conversation

@volodya-lombrozo

Copy link
Copy Markdown
Member

This change aims to add abstract object to the byte representation. Additionally, the PR updates various test cases to reflect the new XMIR format. Closes #4032.

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

@maxonfjvipon Could you review these changes, please?

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 170.827 190.347 19.520 11.43% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 145.740 172.912 27.172 18.64% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 157.747 170.624 12.878 8.16% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 19.520 ms/op (11.43%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToPhi is slower by 27.172 ms/op (18.64%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 12.878 ms/op (8.16%)

@maxonfjvipon maxonfjvipon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo LGTM, like it

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

@yegor256 Could you merge this changes, please?

@yegor256 yegor256 added this pull request to the merge queue Mar 24, 2025
Merged via the queue into objectionary:master with commit bf9e946 Mar 24, 2025
@0crat

0crat commented Mar 25, 2025

Copy link
Copy Markdown

@maxonfjvipon Thanks for the review! Your effort earned you +4 points: +4 base, -24 for self-review, +0.75 for 3 comments, -10 for fewer than 6 comments, and +33.25 to meet the minimum 4-point reward. While self-reviews aren't ideal, your comments are valuable. Keep up the good work! Your current balance is +42.

@0crat

0crat commented Mar 25, 2025

Copy link
Copy Markdown

@volodya-lombrozo 🌟 Fantastic work on your contribution! You've earned a well-deserved +10 points: +4 base, +9 for your impressive 191 hits-of-code, with a small -4 adjustment for minimal comments. Your dedication is driving our project forward! Keep up the great momentum. Your current balance stands at +48. We're excited to see what you'll bring next!

@0crat

0crat commented Mar 25, 2025

Copy link
Copy Markdown

@yegor256 Great job on the review! 🌟 You've earned 4 points: 4 base points, adjusted for the limited comments. Your dedication is appreciated! Keep up the good work to improve your balance, which currently stands at -508. Every contribution counts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bytes-with-anonymous-object.yaml:4-10: XMIR format for...

4 participants