Skip to content

fix(#4976): remove unused alias to ms.abs in real.eo to fix pipelines#4977

Merged
yegor256 merged 1 commit into
objectionary:masterfrom
volodya-lombrozo:4976-fix-broken-pipelines
Apr 6, 2026
Merged

fix(#4976): remove unused alias to ms.abs in real.eo to fix pipelines#4977
yegor256 merged 1 commit into
objectionary:masterfrom
volodya-lombrozo:4976-fix-broken-pipelines

Conversation

@volodya-lombrozo

@volodya-lombrozo volodya-lombrozo commented Apr 6, 2026

Copy link
Copy Markdown
Member

This PR resolves issues in the repository by correcting the alias in ms.real.eo, which was causing pipeline failures.

Related to #4976

Summary by CodeRabbit

  • Chores
    • Removed the ms.abs alias from the runtime module.

Copilot AI review requested due to automatic review settings April 6, 2026 13:27
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 78a4cd25-7e35-4fd6-8f8a-a3b97dc47324

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb0d56 and 3aa5b4a.

📒 Files selected for processing (1)
  • eo-runtime/src/main/eo/ms/real.eo
💤 Files with no reviewable changes (1)
  • eo-runtime/src/main/eo/ms/real.eo

📝 Walkthrough

Walkthrough

A single exported alias ms.abs was removed from the real object declaration in eo-runtime/src/main/eo/ms/real.eo. No logic changes or modifications to the object's functionality were made.

Changes

Cohort / File(s) Summary
Alias Removal
eo-runtime/src/main/eo/ms/real.eo
Removed exported alias declaration +alias ms.abs from the real object header. Aliases ms.e and ms.pow remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 One alias hopped away,
Ms.abs had its day,
Now the code runs clean and tight,
With one less declaration in sight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing an unused alias to ms.abs in real.eo to fix pipelines, which directly matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused ms.abs alias from ms/real.eo, which appears to be triggering EO linting failures in CI (per #4976). The change is narrowly scoped to avoid affecting runtime behavior while unblocking pipelines.

Changes:

  • Removed the unused +alias ms.abs from eo-runtime/src/main/eo/ms/real.eo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 169.330 174.318 4.988 2.95% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 4.988 ms/op (2.95%)

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

@yegor256 could you merge this one, please? It's a critical blocker.

@yegor256
yegor256 merged commit 4c2c97a into objectionary:master Apr 6, 2026
28 of 29 checks passed
@0crat

0crat commented Apr 9, 2026

Copy link
Copy Markdown

@volodya-lombrozo Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (1) hits-of-code (our policy requires at least 40 hits-of-code to avoid this penalty). To maximize your rewards, consider making larger contributions with 40+ hits-of-code while maintaining quality through proper code review. Please, keep them coming. Your running score is +226; don't forget to check your Zerocracy account too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants