Skip to content

bug(#4991): remove binaries and ignore runtime#5029

Merged
yegor256 merged 1 commit into
objectionary:masterfrom
maxonfjvipon:bug/#4991/keep-binaries
Apr 23, 2026
Merged

bug(#4991): remove binaries and ignore runtime#5029
yegor256 merged 1 commit into
objectionary:masterfrom
maxonfjvipon:bug/#4991/keep-binaries

Conversation

@maxonfjvipon

@maxonfjvipon maxonfjvipon commented Apr 23, 2026

Copy link
Copy Markdown
Member

Closes: #4991

Summary by CodeRabbit

  • Chores
    • Optimized Maven build configuration by streamlining binary file retention settings and enabling runtime optimization.

@github-actions github-actions Bot added the core label Apr 23, 2026
@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 937e6ec2-1c5e-418c-999a-5becaa9712aa

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff9b01 and 8d31aad.

📒 Files selected for processing (1)
  • eo-runtime/pom.xml

📝 Walkthrough

Walkthrough

The Maven eo-maven-plugin configuration in eo-runtime/pom.xml is updated by setting ignoreRuntime to true and significantly reducing the keepBinaries list. An extensive set of .class glob patterns and an associated @todo comment are removed, leaving only package-info.class entries in the configuration.

Changes

Cohort / File(s) Summary
Maven Plugin Configuration
eo-runtime/pom.xml
Updated ignoreRuntime setting to true and drastically simplified keepBinaries configuration by removing a large list of .class glob patterns and their associated comment, retaining only package-info.class entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 The Maven pom had too much clutter,
With patterns that made the config mutter,
Now simplified to package-info alone,
The build configuration's cleaner, well-known! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'bug(#4991): remove binaries and ignore runtime' accurately and concisely describes the main changes in the pull request.
Linked Issues check ✅ Passed The pull request successfully addresses issue #4991 by reducing keepBinaries back to package-info.class entries and removing the puzzle text from pom.xml.
Out of Scope Changes check ✅ Passed All changes in the pull request are directly related to resolving issue #4991, with no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 205.422 181.097 -24.325 -11.84% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 24.325 ms/op (11.84%)

@maxonfjvipon

Copy link
Copy Markdown
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit 24038ff into objectionary:master Apr 23, 2026
27 checks passed
@0crat

0crat commented Apr 23, 2026

Copy link
Copy Markdown

@maxonfjvipon Great work on your contribution! 🎉 You've earned +12 points (+16 base, -4 for 151 hits-of-code exceeding our 100 limit). Quality over quantity keeps us moving forward! Your total score is now +99 — check your Zerocracy account for updates and keep the excellent contributions coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeepBinaries Not Being Reduced Back to Package-Info in pom.xml

3 participants