Skip to content

feat(#5179): invalidate SNAPSHOT cache on every build with Janitor#5180

Merged
yegor256 merged 4 commits into
objectionary:masterfrom
volodya-lombrozo:5179-fix-ph-classes
Jun 4, 2026
Merged

feat(#5179): invalidate SNAPSHOT cache on every build with Janitor#5180
yegor256 merged 4 commits into
objectionary:masterfrom
volodya-lombrozo:5179-fix-ph-classes

Conversation

@volodya-lombrozo

Copy link
Copy Markdown
Member

Invalidates the local SNAPSHOT cache on every build to prevent stale generated files from referencing removed classes.

Fixes #5179

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

In other words, I suggest invalidate cache in the 1.0-SNAPSHOT each time we have a fresh build. It's a bit better than disabling cache at all, but of course not so fast with the plain cache. But with the janitor we won't have problems with stale cache anymore.

Build Time
Current branch (Janitor) 4m 48s
master (cache enabled) 3m 40s
master (cache disabled, -Deo.cacheEnabled=false) 5m 14s

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 18651.332 18777.913 126.580 0.68% ms/op Average Time

⚠️ Performance loss: benchmarks.XmirBench.xmirToEO is slower by 126.580 ms/op (0.68%)

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot added the core label Jun 4, 2026
@volodya-lombrozo volodya-lombrozo requested a review from yegor256 June 4, 2026 11:22
@yegor256 yegor256 merged commit 291556d into objectionary:master Jun 4, 2026
24 of 26 checks passed
@0crat

0crat commented Jun 9, 2026

Copy link
Copy Markdown

@volodya-lombrozo Hey! Nice work on that contribution! 🎉 You snagged +12 points this time: started with the standard +16 points but had to dock -4 since you hit 367 hits-of-code (anything over 100 gets penalized). Pro tip: try to keep those contributions smaller and more focused - you'll avoid the penalty and likely get better reviews! Your running score is looking solid at +397, and don't forget to peek at your Zerocracy account for the latest updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eo-runtime compilation fails due to references to removed Ph* classes

3 participants