feat(#4752): add tt.is-digit object#5208
Merged
yegor256 merged 2 commits intoJun 14, 2026
Merged
Conversation
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
asmirnov-backend
force-pushed
the
feat/#4752/is-digit
branch
from
June 14, 2026 15:20
f21cb75 to
8a808df
Compare
Pure-EO `is-digit` checks that `text` contains only decimal digits, needed as a helper for the pure-EO `sprintf` reimplementation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
asmirnov-backend
force-pushed
the
feat/#4752/is-digit
branch
from
June 14, 2026 15:23
8a808df to
03839d1
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Contributor
Author
|
@yegor256, could you please take a look |
asmirnov-backend
added a commit
to asmirnov-backend/eo
that referenced
this pull request
Jun 14, 2026
Part of objectionary#4752. Adds a pure-EO `tt.as-ascii` object that reads a single character as its ASCII numeric value (0-255), by widening the character's byte to the eight bytes `i64` expects and reading it back as a number. It is a small helper needed by the pure-EO `sprintf` reimplementation (and shared by the `up-cased`/`low-cased` siblings, which today each carry a private copy). Split into its own PR to keep the change small, mirroring the earlier `tt.is-digit` PR (objectionary#5208). The name follows the `as-...` value family of the core library (`as-bytes`, `as-i64`, `as-number`) and pairs with the existing sibling `tt.is-ascii`. It ships with inline `+>` tests covering the boundaries of the upper-case (`A`/`Z`), lower-case (`a`/`z`) and digit (`0`/`9`) ranges, plus space, punctuation (`!`) and the last printable character (`~`). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
asmirnov-backend
added a commit
to asmirnov-backend/eo
that referenced
this pull request
Jun 14, 2026
Part of objectionary#4752. Adds a pure-EO `tt.as-ascii` object that reads a single character as its ASCII numeric value (0-255), by widening the character's byte to the eight bytes `i64` expects and reading it back as a number. It is a small helper needed by the pure-EO `sprintf` reimplementation (and shared by the `up-cased`/`low-cased` siblings, which today each carry a private copy). Split into its own PR to keep the change small, mirroring the earlier `tt.is-digit` PR (objectionary#5208). The name follows the `as-...` value family of the core library (`as-bytes`, `as-i64`, `as-number`) and pairs with the existing sibling `tt.is-ascii`. It ships with inline `+>` tests covering the boundaries of the upper-case (`A`/`Z`), lower-case (`a`/`z`) and digit (`0`/`9`) ranges, plus space, punctuation (`!`) and the last printable character (`~`). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@asmirnov-backend Thanks for the contribution! You've earned +16 points following our bonus policy - you received the base 16 points for reviews, plus additional points for your hits-of-code contribution. Please, keep them coming as quality contributions like this help maximize your rewards! Your running score is +16; don't forget to check your Zerocracy account too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4752.
Adds a pure-EO
tt.is-digitobject that checks whethertextcontains only decimal digits. It's a small helper needed by the
pure-EO
sprintfreimplementation (to detect positional argumentindices like
%1$s), split into its own PR to keep the change small.It mirrors the existing sibling objects
tt.is-alpha,tt.is-asciiand
tt.is-alphanumeric: same headers,+alias tt.regex, and inline+>tests.🤖 Generated with Claude Code