Skip to content

refactor(#5226): replace up-cased private ascii with tt.as-ascii#5244

Closed
asmirnov-backend wants to merge 1 commit into
objectionary:masterfrom
asmirnov-backend:feat/5226/up-cased-as-ascii
Closed

refactor(#5226): replace up-cased private ascii with tt.as-ascii#5244
asmirnov-backend wants to merge 1 commit into
objectionary:masterfrom
asmirnov-backend:feat/5226/up-cased-as-ascii

Conversation

@asmirnov-backend

@asmirnov-backend asmirnov-backend commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Part of #5226.

Drops the private nested [char] > ascii helper in tt.up-cased to use object "tt.as-ascii"

Wait's for #5227

@asmirnov-backend
asmirnov-backend marked this pull request as ready for review June 19, 2026 15:37
@asmirnov-backend
asmirnov-backend marked this pull request as draft June 19, 2026 15:39
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 13032.865 12874.269 -158.596 -1.22% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 158.596 ms/op (1.22%)

@asmirnov-backend
asmirnov-backend force-pushed the feat/5226/up-cased-as-ascii branch from e77a861 to 792c01f Compare June 19, 2026 15:45
…s-ascii

Drop the private nested [char] > ascii helper in up-cased and route
code, maxcode, mincode and the distance offset through tt.as-ascii.
Sort the alias metas by label so as-ascii leads. Make distance a
constant and drop +unlint redundant-object, which only guarded it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@asmirnov-backend
asmirnov-backend force-pushed the feat/5226/up-cased-as-ascii branch from 792c01f to 8687013 Compare June 19, 2026 15:52
@asmirnov-backend

Copy link
Copy Markdown
Contributor Author

Closing as redundant — the up-cased changes (drop nested [char] > ascii, route through tt.as-ascii, sort alias metas, drop +unlint redundant-object via distance!) are now covered by #5227 together with the low-cased decoupling.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant