Skip to content

fix(#5224): rename positive-infinity/negative-infinity to pinf/ninf and line-separator to eol#5247

Merged
yegor256 merged 7 commits into
objectionary:masterfrom
volodya-lombrozo:5224-enable-compound-lint
Jun 22, 2026
Merged

fix(#5224): rename positive-infinity/negative-infinity to pinf/ninf and line-separator to eol#5247
yegor256 merged 7 commits into
objectionary:masterfrom
volodya-lombrozo:5224-enable-compound-lint

Conversation

@volodya-lombrozo

Copy link
Copy Markdown
Member

Enables compound-name lint by renaming positive-infinity and negative-infinity to pinf and ninf, and line-separator to eol across eo-runtime sources.

Fixes #5224

@volodya-lombrozo
volodya-lombrozo force-pushed the 5224-enable-compound-lint branch from f0df04e to 8ce87f4 Compare June 22, 2026 08:00
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report
Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 19682.111 19549.922 -132.189 -0.67% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 132.189 ms/op (0.67%)

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

@yegor256 could you merge this one, please?

@yegor256
yegor256 merged commit 96202dd into objectionary:master Jun 22, 2026
25 checks passed
@sonarqubecloud

Copy link
Copy Markdown

@0crat

0crat commented Jun 26, 2026

Copy link
Copy Markdown

@yegor256 Thanks for the review! You've earned +10 points for this: +12 as a basis; +5 for the 574 hits-of-code that you reviewed; -8 for absolutely no comments posted. Your running score is +937; don't forget to check your Zerocracy account too).

@0crat

0crat commented Jun 26, 2026

Copy link
Copy Markdown

@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +16 as a basis; -4 for too many hits-of-code (574 >= 100); -8 for way too many hits-of-code (574 >= 400). Please, keep them coming. Your running score is +484; don't forget to check your Zerocracy account too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compound-name lint is not enabled in pom.xml

3 participants