Skip to content

fixed #5260: return self from floor for values >= 2^52 #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yegor256 merged 1 commit into from
Jun 26, 2026
Merged

fixed #5260: return self from floor for values >= 2^52 #5266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion eo-runtime/src/main/eo/number.eo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@
# the original, so we subtract `1` in that single case.
[] > floor
if. > @
^.is-finite.not
or.
^.is-finite.not
or.
^.gte 4503599627370496
^.lte -4503599627370496
^
if.
trunc.gt ^
Expand Down Expand Up @@ -394,6 +398,18 @@
-5.floor
-5

# Tests that floor of a very large positive number >= 2^52 returns itself.
[] +> tests-floor-of-large-positive-integer
eq. > @
100000000000000000000.floor
100000000000000000000

# Tests that floor of a very large negative number <= -2^52 returns itself.
[] +> tests-floor-of-large-negative-integer
eq. > @
-100000000000000000000.floor
-100000000000000000000

# Tests that floor of zero returns zero.
[] +> tests-floor-of-zero
eq. > @
Expand Down
Loading