Skip to content

#951: Recognize incorrect-unlint as a valid lint name#1027

Merged
rultor merged 1 commit into
objectionary:masterfrom
PALLIEP:951-fix-incorrect-unlint
Jul 16, 2026
Merged

#951: Recognize incorrect-unlint as a valid lint name#1027
rultor merged 1 commit into
objectionary:masterfrom
PALLIEP:951-fix-incorrect-unlint

Conversation

@PALLIEP

@PALLIEP PALLIEP commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Fixes #951.

Summary

LtIncorrectUnlint validates +unlint metas against
MonoLints.ALL_NAMES. However, incorrect-unlint was absent from this
collection because the lint is registered only after ALL_NAMES is
initialized.

This change:

  • adds LtIncorrectUnlint to the collection used to build ALL_NAMES;
  • allows +unlint incorrect-unlint without reporting a false-positive defect;
  • adds a regression test covering the suppression through MonoLints.

Testing

  • mvn -Dtest=MonoLintsTest test
  • mvn clean verify -PskipTests -Pqulice --errors --batch-mode

@volodya-lombrozo

Copy link
Copy Markdown
Member

@rultor merge

@rultor

rultor commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
rultor merged commit 872517f into objectionary:master Jul 16, 2026
21 checks passed
@rultor

rultor commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 4min).

@0crat

0crat commented Jul 16, 2026

Copy link
Copy Markdown

@volodya-lombrozo Thanks for the review! You've earned +4 points for this: +12 as a basis; -8 for absolutely no comments posted; -4 for too few (20) hits-of-code; +4 to give you at least something. Your running score is +457; don't forget to check your Zerocracy account too).

@0crat

0crat commented Jul 16, 2026

Copy link
Copy Markdown

@PALLIEP Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (20) hits-of-code. Please, keep them coming. Your running score is +12; don't forget to check your Zerocracy account too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LtIncorrectUnlint reports +unlint incorrect-unlint as invalid because "incorrect-unlint" is absent from MonoLints.ALL_NAMES

4 participants