#951: Recognize incorrect-unlint as a valid lint name#1027
Merged
Conversation
volodya-lombrozo
approved these changes
Jul 16, 2026
Member
|
@rultor merge |
Contributor
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
Contributor
@volodya-lombrozo Done! FYI, the full log is here (took me 4min). |
|
@volodya-lombrozo Thanks for the review! You've earned +4 points for this: +12 as a basis; -8 for absolutely no comments posted; -4 for too few (20) hits-of-code; +4 to give you at least something. Your running score is +457; don't forget to check your Zerocracy account too). |
|
@PALLIEP Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (20) hits-of-code. Please, keep them coming. Your running score is +12; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #951.
Summary
LtIncorrectUnlintvalidates+unlintmetas againstMonoLints.ALL_NAMES. However,incorrect-unlintwas absent from thiscollection because the lint is registered only after
ALL_NAMESisinitialized.
This change:
LtIncorrectUnlintto the collection used to buildALL_NAMES;+unlint incorrect-unlintwithout reporting a false-positive defect;MonoLints.Testing
mvn -Dtest=MonoLintsTest testmvn clean verify -PskipTests -Pqulice --errors --batch-mode