fix(#992): optimize rt-without-atoms XSL with xsl:key#1040
Open
ImilB wants to merge 1 commit into
Open
Conversation
Signed-off-by: ImilB <kiwiyt09a@gmail.com>
volodya-lombrozo
suggested changes
Jul 16, 2026
volodya-lombrozo
left a comment
volodya-lombrozo
left a comment
Member
There was a problem hiding this comment.
@ImilB Thank you for the contribution! But these changes require some sort of a test. It would be nice to have some proof that these changes are actually improving performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #992.
Problem
The
rt-without-atomsXSL transformation exceeds 100ms threshold on large XMIR files (~128-129ms).Root Cause
The check
not(//o[eo:atom(.)])scans the entire document when no atom is found.eo:atom(.) = exists($o/o[@name=$eo:lambda])performs a child lookup per element.When the XMIR file has no atoms, every element is visited, making the cost O(n × degree).
Solution
Added
xsl:keyfor fast lookup of atoms.