ToolbarAndroid Removed From RN 0.61

[aminosman]

• Review the documentation: https://github.com/oblador/react-native-vector-icons
• Search for existing issues (including closed issues): https://github.com/oblador/react-native-vector-icons/issues

Environment

Description

Looks like React Native removed the ToolbarAndroid component as part of their leaner code initiative.

facebook/react-native#26591

[connectdotz]

looks like the community just went ahead to remove the dependency of ToolbarAndroid, should it be done here as well? Is there any objection to such an approach? Otherwise, it seems easy enough that I can submit a PR...

[connectdotz]

after further discussion in facebook/react-native#26591, react-native team decided to extract ToolbarAndroid to an external package https://github.com/react-native-community/toolbar-android. react-native-vector-icons seems to have a pretty extensive investment in supporting ToolbarAndroid, @oblador do you prefer to remove ToolbarAndroid support or migrate to the new community package? I can work on the PR to unblock us but would like to hear your preference.

[hosseinmd]

It should be imported from react-native-community instead of react-native. But in packages.json should not be inserted in dependencies because this feature is not used by everyone. It is good to add peer dependencies and dev dependencies.

[hosseinmd]

I have a pull request. If any of you have permission, please accept the PR.

[szholdiyarov]

@hosseinmd hey! thanks for your PR
I will have a look at it later today

[forki]

Master works for us. But the last npm version fails because this line did not ship: https://github.com/oblador/react-native-vector-icons/blob/master/lib/toolbar-android.js#L6

Can you please a release a new version?

[dehypnosis]

please release new one. react-native-web stuck now!

workaround for react-app-rewired config-overrides.js

(() => {
  const filePath = require.resolve(`react-native-vector-icons/lib/toolbar-android.js`);
  const code = fs.readFileSync(filePath).toString();
  fs.writeFileSync(filePath, code.replace(`import { ToolbarAndroid } from './react-native';`, `import ToolbarAndroid from '@react-native-community/toolbar-android';`));
})();

add webpack plugin to suppress missing UnimplementedView warning too

new (require("webpack").NormalModuleReplacementPlugin)(
    /^react-native\/Libraries\/Components\/UnimplementedViews\/UnimplementedView$/,
    path.resolve("./__mocks__/empty.js"), // any useless module
),

[arstropica]

It should be imported from react-native-community instead of react-native. But in packages.json should not be inserted in dependencies because this feature is not used by everyone. It is good to add peer dependencies and dev dependencies.

Should this be an optional dependency for non-android builds?

[hosseinmd]

It should be imported from react-native-community instead of react-native. But in packages.json should not be inserted in dependencies because this feature is not used by everyone. It is good to add peer dependencies and dev dependencies.

Should this be an optional dependency for non-android builds?

Yes, but there is bug if you not installed, I have a pull request for that.
#1175

[vitalyiegorov]

This npm script fix can be used in your postinstall stage until repo is updated:
"fix:react-native-vector-icons": "sed -e \"s/import { ToolbarAndroid } from \\'\\.\\/react-native\\';/import ToolbarAndroid from \\'@react-native-community\\/toolbar-android\\';/g\" -i.bak ./node_modules/react-native-vector-icons/lib/toolbar-android.js",

and if you are using customize-cra:

addWebpackPlugin(
  new webpack.NormalModuleReplacementPlugin(
    /^react-native\/Libraries\/Components\/UnimplementedViews\/UnimplementedView$/,
    path.resolve(__dirname + '/empty.js')
  )
),

[JonathanHolvey]

I'm not knowingly using ToolbarAndroid in my project. Is there a way of disabling it within react-native-vector-icons, or must I add it to my project dependencies?