-
Notifications
You must be signed in to change notification settings - Fork 155
An origin option for features that need absolute URLs #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don’t think this should be a command-line flag. It should be a config option. |
Does the existing base option work for this? |
We could choose to make it work, for example when this option is specified as a URL it could be applied to all pages, not only the 404. But we'd need to change the relative paths (as they would now be relative to the base, not to the page). It feels like a different concern (or concept), in that what we need here is the URL of the root of the site. "host", as this was titled, is not enough. |
I didn’t mean to add a |
Oh I see… yes I think you're correct: if the base is an absolute URL, it would have that slightly new meaning (URL of the root of the site) and still be compatible with how we use it for 404.html. |
I thought that’s what it meant. 😅 The docs say “the base path when serving the site.” Or are you saying that “base” would then have “https://…” in it? I didn’t mean that. I just meant enough to compute the absolute path. If we need the absolute URL including the origin then we should add a new config property such as origin. |
ok, so the formula would be (this is what this issue was about originally [but not explicit enough, and the option was called host]). |
Uh oh!
There was an error while loading. Please reload this page.
For anything that needs absolute URLs (#168, #178, #179).
The 404.html page (#174) should also somehow be aware of the server's root (does not need the host option, but the base) if we want to use the same file to serve 404s both at paths containing any sub/paths/ from the home page.(or maybe not, see #194 (comment)).See also discussion under #42.
The text was updated successfully, but these errors were encountered: