-
Notifications
You must be signed in to change notification settings - Fork 153
base configuration option #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
supported in `observable dev`: serves the project under the base, and redirects / to the new base to help the user. However it 404s on any other URL, to avoid false positives. will be used in `observable build` to help the 404 page and more to come.
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
I initially thought that this would be needed to build a useful 404.html page (#174). But here's the twist: if the site is served from https://example.com/base/ it is most probable that the server will not use the generated 404.html file as a template for its 404 errors (since it doesn't live at the server root). In other words: we don't need the base configuration option for #174. Of course, |
It looks like Platform won't need this afterall, since everything uses relative URLs. Given that, I'm going to step down as reviewer. |
Do we need this at all? Maybe not… |
@mythmon do we fix this on the platform or should I revive this issue? (We need to fix https://observablehq.com/framework/404 (#721) in one way or the other.) |
I don't think we need this on the platform. Plus we are moving towards not having a separate build for deploy, so we wouldn't be able to to inject it anyways. |
https://observablehq.com/framework/404 https://observablehq.com/framework/examples/chess/404 (etc.) closes #721 alternative to #194
The base option (for #42), can be set to
/path/to/root/
; defaults to/
.supported in
observable dev
: serves the project under the base, and redirects / to the new base to help the user. However it 404s on any other URL, to avoid false positives.