What is a fileReference name?

[Fil]

As I was reviewing tests in #277, I realized that the fileReference name is a path (like ./test.png), not a basename (test.png). In particular, if you have two fileReferences in the same page, say one to test.png and the other to ./test.png, the name field is arbitrarily the one or the other.

We can normalize that name by removing a starting ./, but it still bugs me that the name is a path (especially since we also have a path field). Note that in build.ts we use this name as a path, when the file is not in the page directory.

[cinxmo]

I understand it as the exact string the user passes to the src attribute or the FileAttachment argument. We could clarify here:
https://github.com/observablehq/cli/blob/052835b46f2748682d036c3c1cec5302e336e142/docs/javascript/files.md?plain=1#L103

[mbostock]

The name has to match what is passed to FileAttachment exactly, so that we can look it up in the map. That is, unless you want to rewrite the argument we pass to FileAttachment, or do some further normalization in resolveFile.

[mbostock]

I agree it would be better if the exposed file.name were just the name and not a path… That’s not something we ever ran into before with notebooks since we didn’t allow paths. 😅

[cinxmo]

I think there's a bug in my code since I de-dup based on file.path but we look up based on file.name...

[cinxmo]

Actually the current implementation is fine since we're not referring to the files via FileAttachment(...). Closing this ticket