Increase test coverage

[cinxmo]

We currently have pretty good test coverage for transpileJavaScript (javascript.ts) and parseMarkdown (markdown.ts), but we're missing test coverage on:

• incremental reloading
• various functions within javascript/
• the html output

We should structure the tests so it is easy to add new tests and increase test coverage

TODO (and current coverage as of 11/23)

• src/auth.ts 82.6% 🟢
• src/build.ts 100% 🟢
• src/config.ts 100% 🟢
• src/dataloader.ts 82.27% 🟢
• src/error.ts 100% 🟢
• src/files.ts 100% 🟢
• src/hash.ts 100% 🟢
• src/html.ts 100% 🟢
• src/info.ts 100% 🟢
• src/javascript.ts 100% 🟢
• src/markdown.ts 85.44% 🟢
• src/pager.ts 100% 🟢
• src/preview.ts 0% 🔴
• src/render.ts 92.92% 🟢
• src/resolver.ts 97.1% 🟢
• src/sourcemap.ts 100% 🟢
• src/tag.ts 100% 🟢
• src/toolConfig.ts 31.48% 🔴
• src/url.ts 100% 🟢
• src/javascript/assignments.ts 100% 🟢
• src/javascript/awaits.ts 100% 🟢
• src/javascript/declarations.ts 100% 🟢
• src/javascript/features.ts 100% 🟢
• src/javascript/fetches.ts 100% 🟢
• src/javascript/globals.ts 100% 🟢
• src/javascript/imports.ts 100% 🟢
• src/javascript/references.ts 100% 🟢
• src/javascript/syntaxError.ts 100% 🟢
• public/client.js 0% 🔴
• public/database.js 0% 🔴

[mbostock]

Here’s current coverage:

Editing top post to enumerate what’s not yet done.

[mbostock]

We’ve made pretty good progress here.

------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------
File              | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                        
------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------
All files         |   84.14 |     90.7 |   93.13 |   84.14 |                                                                                          
 src              |   80.05 |    88.85 |   90.47 |   80.05 |                                                                                          
  auth.ts         |    82.6 |    68.88 |   80.95 |    82.6 | 28-29,59-60,154-164,168-173,190-191,198-199,225-226,236-246,253-255,261-267              
  build.ts        |     100 |    74.19 |     100 |     100 | 37,58,71,77-81,92-95,105                                                                 
  config.ts       |     100 |    96.55 |     100 |     100 | 37                                                                                       
  dataloader.ts   |   95.45 |     85.1 |      90 |   95.45 | 207,211-215,217-220                                                                      
  error.ts        |     100 |      100 |     100 |     100 |                                                                                          
  files.ts        |     100 |      100 |     100 |     100 |                                                                                          
  hash.ts         |     100 |      100 |     100 |     100 |                                                                                          
  html.ts         |     100 |      100 |     100 |     100 |                                                                                          
  info.ts         |     100 |      100 |     100 |     100 |                                                                                          
  javascript.ts   |     100 |      100 |     100 |     100 |                                                                                          
  markdown.ts     |   85.96 |    86.36 |    82.6 |   85.96 | 81-82,99,149-151,164-166,168-170,173-179,234-235,285-287,455-468,471-494,497-500,502-506 
  pager.ts        |     100 |      100 |     100 |     100 |                                                                                          
  preview.ts      |       0 |        0 |       0 |       0 | 1-351                                                                                    
  render.ts       |    92.1 |    70.76 |   93.33 |    92.1 | 22-29,102-105,110,172-173                                                                
  resolver.ts     |    97.1 |    83.33 |     100 |    97.1 | 23-24                                                                                    
  sourcemap.ts    |     100 |    94.73 |     100 |     100 | 37,111                                                                                   
  tag.ts          |     100 |      100 |     100 |     100 |                                                                                          
  toolConfig.ts   |   31.48 |      100 |      20 |   31.48 | 15-19,21-24,26-50,52-54                                                                  
  tty.ts          |     100 |    66.66 |     100 |     100 | 13                                                                                       
  url.ts          |     100 |      100 |     100 |     100 |                                                                                          
 src/javascript   |     100 |    96.92 |     100 |     100 |                                                                                          
  assignments.ts  |     100 |    94.73 |     100 |     100 | 13                                                                                       
  awaits.ts       |     100 |      100 |     100 |     100 |                                                                                          
  declarations.ts |     100 |      100 |     100 |     100 |                                                                                          
  features.ts     |     100 |      100 |     100 |     100 |                                                                                          
  fetches.ts      |     100 |      100 |     100 |     100 |                                                                                          
  globals.ts      |     100 |      100 |     100 |     100 |                                                                                          
  imports.ts      |     100 |    93.75 |     100 |     100 | 90,198,206                                                                               
  references.ts   |     100 |    97.91 |     100 |     100 | 63                                                                                       
  syntaxError.ts  |     100 |      100 |     100 |     100 |                                                                                          
------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------
✨  Done in 3.13s.

We should focus on adding tests for the preview server, which currently has zero coverage! Related #221. And the newly-added Platform functionality that is currently under-testing (toolConfig.ts and auth.ts). Moving this to the Early access milestone as we are sufficiently covered for the Internal access milestone.

[mbostock]

We also need to figure out how to test the client-side code in public. 🤔

[Fil]

With #284 preview.ts is at > 50%!

[mbostock]

Not going to track this explicitly anymore, but more tests always welcome.