-
Notifications
You must be signed in to change notification settings - Fork 153
dataloaders tests #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
dataloaders tests #110
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
.DS_Store | ||
**/.observablehq/cache/ | ||
dist/ | ||
docs/.observablehq/cache | ||
node_modules/ | ||
test/input/build/*/.observablehq/cache | ||
test/output/*-changed.* | ||
test/output/build/*-changed/ | ||
yarn-error.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import {Loader} from "../src/dataloader.js"; | ||
import {readFile} from "node:fs/promises"; | ||
import assert from "node:assert"; | ||
|
||
describe("data loaders are called with the appropriate command", () => { | ||
it("a .js data loader is called with node", async () => { | ||
const loader = Loader.find("test", "dataloaders/data1.txt")!; | ||
const out = await loader.load(); | ||
assert.strictEqual(await readFile("test/" + out, "utf-8"), "node\n"); | ||
}); | ||
it("a .ts data loader is called with tsx", async () => { | ||
const loader = Loader.find("test", "dataloaders/data2.txt"); | ||
const out = await loader!.load(); | ||
assert.strictEqual(await readFile("test/" + out, "utf-8"), "tsx\n"); | ||
}); | ||
it("a .sh data loader is called as a shell script", async () => { | ||
const loader = Loader.find("test", "dataloaders/data3.txt"); | ||
const out = await loader!.load(); | ||
assert.strictEqual(await readFile("test/" + out, "utf-8"), "shell\n"); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
function mytest() { | ||
// TODO: how to make sure this is not called by tsx? (and, does it matter?) | ||
return "node"; | ||
} | ||
|
||
console.log(mytest()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
function mytest2(): string { | ||
return "tsx"; | ||
} | ||
|
||
console.log(mytest2()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#! /usr/bin/env bash | ||
|
||
echo "shell" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted to test this, you could test the error case: if you put TypeScript annotations in a .js file, you should get a syntax error. It’d probably be a good thing to test how
runLoader
handles errors anyway!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that but couldn't make it work, because tsx sends the syntax error anyway since the file extension is js.
(Note that STDERR is passed to the parent (for logging), with the "inherit" option.)
test:
test/dataloaders/data4-error.txt.js