-
Notifications
You must be signed in to change notification settings - Fork 153
move javascript.html to javascript/index.md #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’ll also have to fix relative links, e.g., ./markdown
now should be ../markdown
.
Right, but it's slightly more difficult than that, because now the dev server happily serves both /javascript and /javascript/ with the same contents, though the links should be different. I'll change the main reference link, but it's still a bit of a trap. |
The dev server should redirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks active link highlighting when you click the JavaScript link from the sidebar.
I think I’d rather have /javascript
as the page, rather than /javascript/
, so that it’s parallel to /markdown
and /html
etc. Are we only making this change to workaround an issue with http-server?
Closing since I would prefer to keep the existing structure but please comment if you disagree. |
yes. If http-server is going to be the recommended server, I think we ought to find a way to make the project itself work with it. |
I just tested Github pages with the following file structure:
I don't see settings for http-server that would result in the same behavior; it seems http-server always prioritizes f/ over f.html. A mitigation might be to build f/index.html as a redirect to f.html? (EDIT: see the similar but better suggestion in #174). |
Does disabling the auto index via |
no |
closes #171