Merged
Conversation
closes #170
cinxmo
reviewed
Nov 15, 2023
| let {pathname} = url; | ||
| try { | ||
| const url = new URL(req.url!, "http://localhost"); | ||
| let {pathname} = url; |
Contributor
There was a problem hiding this comment.
should we just clean the req.url so it doesn't end with 2 backslashes? or redirect? I think in this case it's ok to assume that it was just a typo
Contributor
Author
There was a problem hiding this comment.
Suppose you have a link in index.md to the "//" URL; now the dev server returns a 404 instead of crashing, which is what this PR wanted.
We could decide to redirect // to / on the dev server, but it would only hide this problem from the developer, as the link wouldn't work on the build. So my take is that it is better to be strict and error. (But more discussions on what to do on 404s are happening at #174 :) )
cinxmo
approved these changes
Nov 15, 2023
Contributor
cinxmo
left a comment
cinxmo
left a comment
There was a problem hiding this comment.
added a suggestion but there's nothing blocking this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #170