Merged
Conversation
mbostock
force-pushed
the
mbostock/rollup-client
branch
3 times, most recently
from
ec180d5 to
ab4bfa2
Compare
mbostock
force-pushed
the
mbostock/rollup-client
branch
from
ab4bfa2 to
dfa505a
Compare
mbostock
commented
Nov 28, 2023
Comment on lines
+43
to
+44
| const missingFiles = difference(expectedFiles, actualFiles); | ||
| const unexpectedFiles = difference(actualFiles, expectedFiles); |
mbostock
commented
Nov 28, 2023
| export async function rollupClient(clientPath = getClientPath(), {minify = false} = {}): Promise<string> { | ||
| const bundle = await rollup({input: clientPath, external: ["./runtime.js", /^https:/]}); | ||
| try { | ||
| const output = await bundle.generate({format: "es", plugins: minify ? [(terser as any)()] : []}); |
Member
Author
There was a problem hiding this comment.
The terser as any here fixes a TypeScript error I don’t understand:
This expression is not callable.
Type 'typeof import("/Users/mbostock/Development/observablehq-multi/cli/node_modules/@rollup/plugin-terser/types/index")' has no call signatures.ts(2349)
It seems like TypeScript isn’t resolving the types correctly. 🤷
mbostock
force-pushed
the
mbostock/rollup-client
branch
from
832b9a1 to
6ecd8c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61. Fixes #233 (trivally; we can add tree shaking if we want to cut code size further). The diff is a bit large, but there are only a couple trivial changes to the code to break it up into more manageable files.
This uses a dedicated entry point for preview such that in build we don’t include the
openfunction, reducing code size.In followup PRs, I would like to: