Skip to content

Redirect /subdir to /subdir/ when the page is given by docs/subdir/index.md #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbostock merged 3 commits into from
Nov 29, 2023
Merged

Redirect /subdir to /subdir/ when the page is given by docs/subdir/index.md #274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffffe63
Redirect /subdir to /subdir/ when the page is given by docs/subdir/in…
Fil Nov 29, 2023
b25d274
more precise redirection:
Fil Nov 29, 2023
68bb7f5
remove redundant check
Fil Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ export class PreviewServer {
try {
if ((await stat(path)).isDirectory() && (await stat(join(path, "index") + ".md")).isFile()) {
await access(join(path, "index") + ".md", constants.R_OK);
if (!pathname.endsWith("/")) {
res.writeHead(302, {Location: pathname + "/" + url.search});
res.end();
return;
}
pathname = join(pathname, "index");
path = join(path, "index");
}
Expand Down
4 changes: 3 additions & 1 deletion test/input/build/multi/subsection/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Sub-Section

This is a sub-section of the multi-section page.
This is a sub-section of the multi-section page.

We can link to [this sub-section](./) and to [the parent section](../).
1 change: 1 addition & 0 deletions test/output/build/multi/subsection/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<main id="observablehq-main" class="observablehq">
<h1 id="sub-section" tabindex="-1"><a class="observablehq-header-anchor" href="#sub-section">Sub-Section</a></h1>
<p>This is a sub-section of the multi-section page.</p>
<p>We can link to <a href="./">this sub-section</a> and to <a href="../">the parent section</a>.</p>
</main>
<footer id="observablehq-footer">
<nav><a rel="prev" href="../"><span>Home</span></a></nav>
Expand Down