Sidebar updates #380
Closed
Sidebar updates #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Dec 14, 2023
cinxmo
commented
Dec 14, 2023
| --theme-foreground: #1C1C1C; | ||
| --theme-foreground-highlight: #001B440D; | ||
| --theme-foreground: #1c1c1c; | ||
| --theme-foreground-highlight: rgb(242,244,246); |
There was a problem hiding this comment.
"highlight" refers to the lighter gray color in the back and "focus" refers to the text and left border color
There was a problem hiding this comment.
It should be called --theme-background-… if it’s a background color. And we already have --theme-background-alt for this purpose.
Speaking of which is looks like --theme-background-alt is broken in production since it’s set to the same color as --theme-background, so code blocks are no longer gray. 😞
|
Superseded by #386. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.