dashboard theme + theme and style documentation #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mbostock
reviewed
Jan 7, 2024
mbostock
reviewed
Jan 7, 2024
mbostock
force-pushed
the
fil/theme-dashboard
branch
from
3fa110a to
7ae78c5
Compare
mbostock
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the dashboard theme does not try to control colors; this makes it compatible with auto, light and dark, and the result does not depend on the order in which the themes are specified.
However, this means that the dashboard theme does not stand on its own, and must be specified together with one of dark, light or auto. I haven't found a neat way to, say, have it use auto implicitly when the page is set to
theme: dashboard.TODO: