Merged
Conversation
mbostock
requested changes
Jan 8, 2024
Member
mbostock
left a comment
mbostock
left a comment
There was a problem hiding this comment.
Should the footer be nullable, too? I guess you could always set it to an empty string, but if it’s null we could avoid emitting the <div> in renderFooter, too.
Just missing some coercion…
Contributor
Author
|
Do you think we should consider null to not create the div, and "" to create an empty div? I went for the simpler where null is not supported, and "" does not create the div. |
mbostock
approved these changes
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #55