-
Notifications
You must be signed in to change notification settings - Fork 154
Inputs overview #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Inputs overview #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allisonhorst
commented
Jan 12, 2024
•
edited
Loading
edited
- Adds an Inputs overview page to JavaScript section (should title be "Observable Inputs" in sidebar?)
- Includes view() information, slightly updated from what was in Displays to limit redundancy
- Includes examples and text from Hello, Inputs! in hopes that we can point to a single place for a broad inputs overview, with examples (but I'm curious if you all think it works...)
Fil
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we remove the word "component" throughout, and use input instead. Similarly we should lowercase all the inputs' names.
Co-authored-by: Philippe Rivière <[email protected]>
Fil
reviewed
Jan 12, 2024
Co-authored-by: Philippe Rivière <[email protected]>
Fil
approved these changes
Jan 12, 2024
This was referenced Jan 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.