-
Notifications
You must be signed in to change notification settings - Fork 154
add resize doc #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resize doc #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just say
`resize`
instead of
**`resize()`**
when referencing the resize
function? I don’t think we need so many different special typographic treatments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, and apologies for the duplicate effort, but I just added documentation for resize
as part of #555 by way of moving it from the Dash library to the standard library.
I do think it would be nice to document the special behavior with one argument (width
), the use of position: absolute to prevent a feedback loop, the support for the invalidation
promise as an optional argument after the render function, the fact that it uses ResizeObserver under the hood, the fact that it requires a wrapper element, etc. But also not a high priority.
no worries. how about i wait for #555 to land then i can reconcile what's in there and the suggestions above. |
@mbostock i've added the i'm merging this up into components so we can move that all along. we change/remove this section if winds up redundant. |
adding doc for resize. @mbostock i'm adding you for review here as i wanted to be sure i wasn't missing nuance on
resize()