Skip to content

Adds Grouping data (with hexbin, histogram) in Charts #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

allisonhorst
Copy link
Contributor

Addresses Mike's feedback in #522 :

To align with Plot’s mental model, perhaps better to combine this and the hexbin example into a bin.md that demonstrates group, bin, and hexbin transforms?

This update:

  • Combines hexbin and histogram snippets into a single page, docs/charts/grouping-data.md
  • Removes separate hexbin, histogram pages
  • Updates observablehq.config.ts
  • I did not move over two bar chart examples that use group transforms (Top 10 sorted, weighted sum), thinking that users would be more likely to look in the "Bar" page for those. Happy to move if they should also be in the grouping-data.md page.
  • Current naming: "Grouping data" in sidebar, and as page title.

@allisonhorst allisonhorst requested review from Fil and mbostock January 18, 2024 00:08
@allisonhorst allisonhorst mentioned this pull request Jan 18, 2024
9 tasks
@mbostock mbostock changed the base branch from main to allison/components-overview January 18, 2024 00:16
@allisonhorst allisonhorst changed the base branch from allison/components-overview to components January 18, 2024 01:59
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few small suggestions

Co-authored-by: Philippe Rivière <[email protected]>
@allisonhorst allisonhorst merged commit 1b197cc into components Jan 18, 2024
@allisonhorst allisonhorst deleted the allison/plot-snippets branch January 18, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants