-
Notifications
You must be signed in to change notification settings - Fork 153
download npm imports; parser & resolver improvements #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
053273e
only include needed bundles
mbostock 1fcf258
download npm imports
mbostock da717fd
better content-type; remove sourcemap
mbostock f5c5df4
only rewrite javascript
mbostock 28c5e61
fix test snapshots
mbostock bb1b395
fix stylesheet resolution
mbostock 47620f2
npm resolution is now mandatory
mbostock b0a2e9d
resolve using cache
mbostock d60ed2b
coalesce concurrent requests
mbostock ee1865e
docs/.observablehq/cache/_npm
mbostock 68fe32c
rewrite npm imports by parsing
mbostock 5a3d47f
collect global imports
mbostock b2e726e
Merge branch 'mbostock/prune-bundles' into mbostock/download-npm
mbostock fda5c4d
files.length
mbostock d8115e8
implicit file imports
mbostock a86ce48
getImplicitFileImports tests
mbostock f25d2e7
Merge branch 'main' into mbostock/download-npm
mbostock 37243ca
avoid port conflict
mbostock 8c65959
rename for clarity
mbostock 3cd842b
Merge branch 'main' into mbostock/download-npm
mbostock 9e20ee0
Merge branch 'main' into mbostock/download-npm
mbostock 3c6512a
fix link rewriting
mbostock 3bd09b6
cleaner path
mbostock 93f71d7
checkpoint build
mbostock 676c90d
partially fix imports
mbostock 2853569
more import resolution fixes
mbostock d5f36c9
duckdb & sqlite wasm downloads
mbostock 45f3025
only parse .js for transitive imports
mbostock bcb9205
fix import.meta.resolve
mbostock f44e5ec
addImplicitDownloads
mbostock 308c4af
comment re. katex stylesheet
mbostock 4601f26
Merge branch 'main' into mbostock/download-npm
mbostock f3e618e
checkpoint getFiles
mbostock 42392bc
remove findImportDeclarations
mbostock 4e7e07e
resolve path; more tests
mbostock cd9f14d
more tests
mbostock a5228ea
assignment tests
mbostock 0a46050
adopt findFiles for parseLocalImports
mbostock 2394a57
remove findFeatures
mbostock 4009fb2
finish findFileAttachments migration
mbostock c2438af
bound-path createImportResolver
mbostock 7b7ea6d
serve vs. source path
mbostock 2b47d79
more file cleanup
mbostock 24af5c4
fix type import
mbostock 0262b98
simpler import resolution
mbostock b12f980
root-aware resolution
mbostock 919e76a
more import resolution
mbostock 35efbcb
remove todo
mbostock 8f50421
checkpoint
mbostock bc9dbb6
checkpoint
mbostock c0f9e3e
checkpoint
mbostock 8986c73
checkpoint
mbostock 457369c
checkpoint
mbostock c6dd38d
checkpoint
mbostock 301fcf0
working preview again!
mbostock 73da98f
fix file watching!
mbostock 90c758b
remove test code
mbostock b836240
remove caveat!
mbostock d864353
fix data loader file hash
mbostock 3a90984
tidy
mbostock 2d8d0e8
Merge branch 'main' into mbostock/download-npm
mbostock fb7ae77
more better
mbostock d17d7c5
minimize diff
mbostock d3c8e7a
more tests
mbostock a89ec03
more tests
mbostock 552aba7
fix dissolving head
mbostock f100a09
more tests
mbostock 8f8834f
Merge branch 'main' into mbostock/download-npm
mbostock 01b8fc9
resolve dynamic imports to jsDelivr
mbostock 352742f
self-host dynamic imports; fix mermaid dist
mbostock 02d105f
comments
mbostock 262b498
comments
mbostock 4a48e92
comments
mbostock 5c0ef75
more tests
mbostock ab26f0c
more tests
mbostock 5a03ad2
JavaScript parse tests
mbostock c901851
more tests
mbostock eb3df9d
fix style coercion
mbostock 9a9a786
build fixes
mbostock aeb206f
more build fixes
mbostock 60d0c7d
build works?
mbostock bfa7e51
fix deploy!
mbostock 320630b
build fixes
mbostock 058e72f
fix npm: stylesheets
mbostock ccf8221
more downloads
mbostock 31de643
fix vega-lite
mbostock f040e81
fix a couple pages
mbostock 93f0d25
jsdom
mbostock 6cf31fe
simpler tocSelector
mbostock c65e9fd
move html rewriting to rendering
mbostock 1cdbe61
fix hash, sort of
mbostock ee4cf53
cleaner
mbostock 1182211
content-hashed file names
mbostock 3feefce
fix build tests
mbostock dba8eee
tree-shake @observablehq/runtime
mbostock 1df91e4
remove unused import
mbostock 9af1b34
handle missing files
mbostock c60547e
content-hashed module names
mbostock e4afd92
content-hashed search index
mbostock 12208f3
content-hashed stylesheets; fix search
mbostock 2687b3c
fix tip </div>
mbostock 796f415
fix for moved cells
mbostock 9694b24
Merge branch 'main' into mbostock/download-npm
mbostock 5f00239
fix </code>
mbostock 5e9497b
fix head: false
mbostock 64c7875
hide searchInput
mbostock 21f4484
keepNames: true
mbostock 9b73d0c
fix shp dbf
mbostock b4aa2ec
fix canvas max-width
mbostock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export const bar = "bar"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export {bar} from "./bar.js" | ||
export const foo = 42; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because Vega-Lite infers the format type from the file extension (
.csv
), but doesn’t check for the query string and so is confused by the now-present?sha=…
. It’s better to be explicit about the format anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file url
/_file/lib/gistemp.08e51068.csv
is ending in.csv
again, so all is well with both versions of the code.