Skip to content

Markers (and the tree mark) should use a CSS variable instead of white #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbostock opened this issue Apr 18, 2023 · 0 comments · Fixed by #1489
Closed

Markers (and the tree mark) should use a CSS variable instead of white #1463

mbostock opened this issue Apr 18, 2023 · 0 comments · Fixed by #1489
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

In dark mode, the white stroke on the circle marker doesn’t have the intended effect:

Screenshot 2023-04-18 at 10 50 22 AM

If markers used a CSS variable instead of hard-coding white, it’d be easier to override the stroke color when in dark mode using an external stylesheet. Related #1434.

@mbostock mbostock added the enhancement New feature or request label Apr 18, 2023
This was referenced Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant