Skip to content

Plot’s default background: white often isn’t a great default #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbostock opened this issue Apr 7, 2023 · 0 comments · Fixed by #1489
Closed

Plot’s default background: white often isn’t a great default #1434

mbostock opened this issue Apr 7, 2023 · 0 comments · Fixed by #1489
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

mbostock commented Apr 7, 2023

The background: white is nice for generating opaque screenshots when using Download PNG on Observable, but it makes it harder to use Plot in another web application, say with a dark theme—especially because Plot’s foreground color defaults to currentColor and not black. When Plot supports themes #630 (configurable defaults), it might makes sense to have the default background: white only apply on Observable. Perhaps we can have a workaround in the interim, say by looking at location.origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant