Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

1-line bug (--plot-background: white;) #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryancwalsh opened this issue Jun 10, 2024 · 0 comments
Closed

1-line bug (--plot-background: white;) #2080

ryancwalsh opened this issue Jun 10, 2024 · 0 comments
Labels
bug Something isn’t working

Comments

@ryancwalsh
Copy link

Thanks for your amazing library. We're super excited about it!

This line of this commit was a mistake, right?

image

4baad4d#diff-30ab29a77cf3887e9e7e3ec68157a17e77e891ca7d6335074ab995ab1f27b82fR258-R265

I know it was meant to address #1434.

--plot-background: white;

I assume what we want is:

  background: var(--plot-background);

Right now, my tooltips look bad when my app is in dark mode (because the --plot-background gets overridden to white for this SVG.

image

If you have any quick tips for how to resolve, I'd appreciate it.

Thanks.

@ryancwalsh ryancwalsh added the bug Something isn’t working label Jun 10, 2024
walsh-rose-ai added a commit to walsh-rose-ai/observablehq_plot that referenced this issue Jun 10, 2024
@observablehq observablehq locked and limited conversation to collaborators Jun 10, 2024
@Fil Fil converted this issue into discussion #2081 Jun 10, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

1 participant