Skip to content

fontSize should be a channel #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbostock opened this issue Apr 2, 2021 · 0 comments · Fixed by #300
Closed

fontSize should be a channel #296

mbostock opened this issue Apr 2, 2021 · 0 comments · Fixed by #300
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

mbostock commented Apr 2, 2021

No description provided.

@mbostock mbostock added the enhancement New feature or request label Apr 2, 2021
Fil added a commit that referenced this issue Apr 5, 2021
Interestingly, the result is quite smaller than a circle defined with the same accessor. So it seems that we need to introduce fontSizeAdjust (which isn't much supported https://caniuse.com/font-size-adjust), and rescale the resulting channel values in the font-size attribute. See for example https://observablehq.com/d/f5698ebfc65d2b5c#FSA

closes #296
mbostock pushed a commit that referenced this issue Apr 10, 2021
* text font-size as a channel, bound to the scale *r*

Interestingly, the result is quite smaller than a circle defined with the same accessor. So it seems that we need to introduce fontSizeAdjust (which isn't much supported https://caniuse.com/font-size-adjust), and rescale the resulting channel values in the font-size attribute. See for example https://observablehq.com/d/f5698ebfc65d2b5c#FSA

closes #296

* fontSize is an unscaled numerical channel

* fix tests
frontend-provider pushed a commit to frontend-provider/plot that referenced this issue Sep 20, 2023
* text font-size as a channel, bound to the scale *r*

Interestingly, the result is quite smaller than a circle defined with the same accessor. So it seems that we need to introduce fontSizeAdjust (which isn't much supported https://caniuse.com/font-size-adjust), and rescale the resulting channel values in the font-size attribute. See for example https://observablehq.com/d/f5698ebfc65d2b5c#FSA

closes observablehq/plot#296

* fontSize is an unscaled numerical channel

* fix tests
backend-devloper pushed a commit to backend-devloper/plot that referenced this issue Nov 24, 2023
* text font-size as a channel, bound to the scale *r*

Interestingly, the result is quite smaller than a circle defined with the same accessor. So it seems that we need to introduce fontSizeAdjust (which isn't much supported https://caniuse.com/font-size-adjust), and rescale the resulting channel values in the font-size attribute. See for example https://observablehq.com/d/f5698ebfc65d2b5c#FSA

closes observablehq/plot#296

* fontSize is an unscaled numerical channel

* fix tests
tigrevol8888 added a commit to tigrevol8888/plot that referenced this issue Jul 5, 2024
* text font-size as a channel, bound to the scale *r*

Interestingly, the result is quite smaller than a circle defined with the same accessor. So it seems that we need to introduce fontSizeAdjust (which isn't much supported https://caniuse.com/font-size-adjust), and rescale the resulting channel values in the font-size attribute. See for example https://observablehq.com/d/f5698ebfc65d2b5c#FSA

closes observablehq/plot#296

* fontSize is an unscaled numerical channel

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant