If y is ordinal, chose a smarter default height based on the domain’s cardinality? #323
Labels
enhancement
New feature or request
Comments
mbostock
changed the title
|
(Possibly it needs to be multiplied by the cardinality of the fy domain when faceting?) |
Merged
mbostock
added a commit
that referenced
this issue
May 3, 2021
* automatic height closes #323 * fix tests * if y is not ordinal, give it some more space as if it were or cardinality 6 * - use the computed domain - y is always either ordinal or quantitative - fy is always ordinal * tidy * tweak autoHeight * fix non-ordinal autoHeight * automatic height closes #323 * rebase * rebase more * plot outputs * (auto-height:) with vertical facets, the base height for a cell is half that of a usual plot * tweak autoHeight Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the height of a chart with a y-scale defaults to 396. It’d be nice if y were ordinal that we chose a height that’s appropriate based on the cardinality of the domain. E.g., perhaps ensuring a nice round bandwidth of exactly 19px pixels (with the default padding of 0.1). We’d probably want a minimum and maximum default height if we do this.
The text was updated successfully, but these errors were encountered: