Skip to content

Text marks do not support stroke and strokeOpacity as channels. #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbostock opened this issue Jul 31, 2021 · 0 comments · Fixed by #469
Closed

Text marks do not support stroke and strokeOpacity as channels. #467

mbostock opened this issue Jul 31, 2021 · 0 comments · Fixed by #469
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

stroke and strokeOpacity are documented as standard mark channels, but they are not supported on text marks. (Related, rules also do not yet support strokeOpacity as channel #466, and in the near future, strokeWidth may become a standard mark channel #311.)

My inclination is that we should probably support these as channels on text marks, even if they will almost never be used; alternatively, we could explicitly call out in the documentation that these standard channels are not supported on text marks, but that would leave a gotcha for anyone who doesn’t exactingly read the full documentation.
@mbostock mbostock added the bug Something isn’t working label Jul 31, 2021
mbostock added a commit that referenced this issue Jul 31, 2021
@mbostock
fix #467; text stroke channels
6482e46
@mbostock mbostock mentioned this issue Jul 31, 2021
Merged
mbostock added a commit that referenced this issue Aug 2, 2021
@mbostock @Fil
text stroke channels (#469)
2f326d2 
* fix #467; text stroke channels

* add wordCloud test

* a more representative word cloud

Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

text stroke channels observablehq/plot
1 participant
@mbostock