Skip to content

Hide empty facets? #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbostock opened this issue Jan 12, 2021 · 2 comments
Closed

Hide empty facets? #97

mbostock opened this issue Jan 12, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mbostock
Copy link
Member

E.g., here:

image

It’s relatively easy to do this for marks, but it’ll be a little more work to do it for grid lines.

@Fil
Copy link
Contributor

Fil commented Jan 12, 2021

I suppose this should be an option?

For the mark, it seems that it's just a matter of testing if (marksIndexByFacet.has(key)) in

for (let i = 0; i < marks.length; ++i) {
(reference: 96ad3fe )

For the grid lines, I'm struggling to find a solution that would use only a marginal change. The correct solution might be to move the grid lines from the axes' render loop to the facets'.

Fil added a commit that referenced this issue Jan 14, 2021
@mbostock mbostock added the enhancement New feature or request label Feb 24, 2021
@mbostock mbostock added this to the Friends Preview milestone Feb 24, 2021
@Fil Fil self-assigned this Mar 3, 2021
@mbostock mbostock removed this from the Friends Preview milestone Mar 10, 2021
@Fil Fil mentioned this issue Apr 19, 2021
3 tasks
@mbostock
Copy link
Member Author

Fixed in #516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants