rename transforms #104
Closed
rename transforms #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/transform-rename
branch
2 times, most recently
from
4216521 to
a3ebcf2
Compare
mbostock
force-pushed
the
mbostock/transform-rename
branch
from
a3ebcf2 to
70e99dd
Compare
|
👍 I vote it up, as it makes more intuitive sense to me to imagine the y meaning "variable height bars" (ie. "group stuff to make vertical bars" rather than "group on horizontal"). And it indicates that we have "transform then mark", a notion which isn't present in the binX/groupX notation. |
|
Related: sources of confusion with y marks. |
|
Superseded by #176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145.
Transformed marks now use the naming convention {transform}{mark}, making the underlying type of mark clearer, and also allowing the transforms to have simpler names.
Transforms:
Marks:
What do you think? Good idea? Bad? 👍 👎