Skip to content

avoid adding extra spaces when beautifying svg:text elements… #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Sep 28, 2022

that contain tspans.

These result in unreliable positioning.
See #1061 (comment)

Reference:
https://github.com/beautify-web/js-beautify/blob/6fa891e982cc3d615eed9a1a20a4fc50721bff16/js/src/html/options.js#L53
(note that I didn't copy the whole list of tags, only those that we use in the tests).

…tain tspans.

These result in unreliable positioning.
See #1061 (comment)
@Fil Fil requested review from enjalot and mbostock September 28, 2022 08:39
@Fil Fil mentioned this pull request Sep 28, 2022
@Fil Fil merged commit aa4f690 into main Sep 29, 2022
@Fil Fil deleted the fil/beautify-tspan branch September 29, 2022 07:09
Fil added a commit that referenced this pull request Sep 29, 2022
Fil added a commit that referenced this pull request Sep 30, 2022
* text with frameAnchor: bottom should be correctly aligned with the frame, not one line below
closes #1043

* test fixed by #1062

* since the sum (strict window) ignores the first 6 days, feels nicer to ignore them from the domain as well.
@mbostock mbostock mentioned this pull request Jan 3, 2023
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants