Facet expand #1069
Closed
Facet expand #1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2022
…and definitions wraps the complexity of facet reindexing in a more expressive API offers an option to expand channels that are not listed as knownChannels
…ative test for a customMark.
mbostock
reviewed
Oct 10, 2022
mbostock
reviewed
Oct 10, 2022
mbostock
reviewed
Oct 10, 2022
mbostock
reviewed
Oct 10, 2022
mbostock
reviewed
Oct 10, 2022
mbostock
reviewed
Oct 10, 2022
mbostock
reviewed
Oct 10, 2022
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
|
I want to revisit this and see if a smaller fix is possible. Though, it’s still currently fairly edge case since (I believe) you can only trigger it using the exclude facet mode in conjunction with certain transforms (namely stack; not sure if others). |
This was referenced May 28, 2023
|
superseded by #1649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand all channels in parallel to the facet reindexation.
Alternatives: #1068, #1070.TODO:
[x] offer an option to expand more (unlisted) channels—or to list more channels(?)we'll expose registerChannel later