Skip to content

combine prettier into main workflow #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2023
Merged

combine prettier into main workflow #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ jobs:
- run: yarn --frozen-lockfile
- run: |
echo ::add-matcher::.github/eslint.json
yarn run eslint . --format=compact
yarn run eslint src test --format=compact
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the eslint . works in CI because we haven’t generated any files yet (whereas it will fail locally with errors on generated files in build and types). So, this is just being more explicit about what we’re testing so that it’s not confusing when you try to run this command locally.

- run: yarn run prettier --check src test
- run: yarn test
- name: Test artifacts
uses: actions/upload-artifact@v3
Expand Down
23 changes: 0 additions & 23 deletions .github/workflows/prettier.yml
View file
Open in desktop

This file was deleted.