minimal support for bigint#1279
Merged
Merged
Conversation
|
I'll try to take a hack at it this afternoon 👍 |
mbostock
approved these changes
Feb 16, 2023
mbostock
left a comment
mbostock
left a comment
Member
There was a problem hiding this comment.
I suspect there are some further tweaks we can make to coercion but this seems like a good incremental step forward!
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Co-authored-by: Mike Bostock <mbostock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1278
@llimllib see if you can break this branch by passing bigints to unsuspected places (a build is available at https://observablehq.com/@observablehq/plot-bigint-1278 )… note that we're supporting bigints only as channel values, not as options (e.g. we don't try to support
inset: 1normargin: 10n).As I was researching all the places where we coerce values to a number, I realized that this line is probably redundant, as we enter inferLogDomain only with already-coerced channels:
plot/src/scales/quantitative.js
Line 293 in d8378f0