strict range interval, nice interval #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
commented
Mar 14, 2023
| const interval = maybeInterval(thresholds); | ||
| if (interval !== undefined) return interval; | ||
| throw new Error(`invalid thresholds: ${thresholds}`); | ||
| return maybeUtcInterval(thresholds); |
Member
Author
There was a problem hiding this comment.
At this point, we’ve already checked that typeof thresholds === "string", so the other code paths should not be possible.
mbostock
commented
Mar 14, 2023
| export interface AxisYOptions extends AxisOptions, TickYOptions {} | ||
|
|
||
| export interface GridXOptions extends GridOptions, RuleXOptions {} | ||
| export interface GridXOptions extends GridOptions, Omit<RuleXOptions, "interval"> {} |
Member
Author
There was a problem hiding this comment.
This is needed because the rule mark allows a base (non-range) interval, whereas the grid mark requires a range interval. You can widen a type when extending, but you can’t narrow it.
mbostock
force-pushed
the
mbostock/range-interval
branch
from
a25ccb0 to
eb8587f
Compare
Fil
approved these changes
Mar 14, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* strict range interval * nice intervals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1331.
Fixes #1240.
(Also fixes #1333 as a duplicate of #1240)