Skip to content

document link #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 30, 2023
Merged

document link #1388

merged 4 commits into from
Mar 30, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 25, 2023 •
edited
Loading

for #1343

note: more precise jsdoc for the curve option

todo:

  • maybeSameValue

@Fil Fil requested a review from mbostock March 25, 2023 17:19
@Fil Fil mentioned this pull request Mar 25, 2023
Closed
56 tasks
mbostock
mbostock reviewed Mar 25, 2023
View reviewed changes
mbostock
mbostock reviewed Mar 25, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation for the maybeSameValue defaults?

@mbostock mbostock enabled auto-merge (squash) March 30, 2023 21:48
@mbostock mbostock merged commit 0542835 into main Mar 30, 2023
@mbostock mbostock deleted the fil/ts-link branch March 30, 2023 21:51
@Fil
Copy link
Contributor Author

Fil commented Mar 30, 2023 •
edited
Loading

Unnecessary repetition of instead:

   * If the plot uses a spherical **projection**, the default *auto* **curve**
   * will render links as geodesics; to draw a straight line instead, use the
   * *linear* **curve** instead.

@mbostock
Copy link
Member

Thanks, I will fix.

chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
@Fil @mbostock @chaichontat
document link (observablehq#1388)
556971a 
* document link

* Update src/marks/link.d.ts

Co-authored-by: Mike Bostock <[email protected]>

* document link maybeSameValue

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fil @mbostock