Skip to content

circular images, clip css basic shapes #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Apr 3, 2023

support for CSS basic shapes in the mark’s clip option

the r option of the image mark sets a default width = 2*r, and a default clip=circle()

todo:

  • variable r, associated with the r scale
  • complete documentation

closes #1413

the **r** option of the image mark sets a default width = 2*r, and a default clip=circle()

closes #1413
@Fil Fil requested a review from mbostock April 3, 2023 17:16
@Fil Fil marked this pull request as draft April 4, 2023 03:37
@Fil Fil marked this pull request as ready for review April 4, 2023 10:29
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wasn’t thinking we would expose the full functionality of CSS clip-path. (Though this isn’t allowing the path(…) syntax that clip-path supports.) I was just thinking of r for the image mark.

@Fil
Copy link
Contributor Author

Fil commented Apr 4, 2023

OK to keep it internal and limited to the image mark. The ellipse test was just a test :)

@Fil Fil changed the title circular images, clip css basic shapes circular images Apr 5, 2023
@Fil Fil changed the title circular images circular images, clip css basic shapes Apr 5, 2023
@Fil Fil mentioned this pull request Apr 5, 2023
@Fil
Copy link
Contributor Author

Fil commented Apr 5, 2023

superseded by #1425

@Fil Fil closed this Apr 5, 2023
@Fil Fil deleted the fil/clip-basic-shapes branch August 23, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular images
2 participants