Conversation
Fil
commented
Aug 16, 2023
a03f3ff to
e465b79
Compare
mbostock
reviewed
Aug 16, 2023
Member
mbostock
left a comment
There was a problem hiding this comment.
Let’s move this to a “Custom marks” section on the Marks page, like we do for “Custom transforms” on the Transforms page.
Member
|
Should we also document the other public Mark methods, and add them to the Mark class TypeScript declaration? Specifically:
(I also thought about all the public fields on Mark and subclasses, such as mark.data, mark.sort, mark.initializer, etc. But I don’t really want those to be part of the public API. 🤔) |
This was referenced Aug 25, 2023
Merged
mbostock
reviewed
Nov 4, 2023
mbostock
reviewed
Nov 4, 2023
mbostock
reviewed
Nov 4, 2023
mbostock
reviewed
Nov 4, 2023
mbostock
reviewed
Nov 4, 2023
mbostock
reviewed
Nov 4, 2023
mbostock
reviewed
Nov 4, 2023
d076ff2 to
c11ea37
Compare
7053651 to
abf9788
Compare
33df130 to
a74892a
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we do an “Extending Plot” page, maybe it should cover more than the render function?
For #1711