reduce specificity of generated stylesheets to 0 #1941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By reducing the specificity of selectors in the generated stylesheets to 0, consumers of Plot can much more easily override these styles using their own stylesheets while still enjoying the default styling of Plot.
Because the change in selector specificity affects every chart, all snapshots will need regenerating. The rendered output should yield no differences however.
This test renders two categorical legends, one using default Plot styles and the other using styles by setting the `className` option. The styles being overridden have the same selector specificity as those set by Plot, would it not be for the `:where()` selector resetting Plot's specificity to 0. This is easily verified by reverting b2ff68e.
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* fix!: reduce specificity of generated stylesheets to 0 By reducing the specificity of selectors in the generated stylesheets to 0, consumers of Plot can much more easily override these styles using their own stylesheets while still enjoying the default styling of Plot. * chore: generate new snapshots Because the change in selector specificity affects every chart, all snapshots will need regenerating. The rendered output should yield no differences however. * chore: add simple test case for style overrides This test renders two categorical legends, one using default Plot styles and the other using styles by setting the `className` option. The styles being overridden have the same selector specificity as those set by Plot, would it not be for the `:where()` selector resetting Plot's specificity to 0. This is easily verified by reverting b2ff68e. --------- Co-authored-by: Marcus Stade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1930.